feat: migrate ExpirationTransactionScript to package#3111
Merged
Conversation
TomasArrachea
force-pushed
the
tomasarrachea-migrate-to-package
branch
from
9413ded to
e67177a
Compare
TomasArrachea
force-pushed
the
tomasarrachea-standards-miden-project
branch
2 times, most recently
from
3ef6a1b to
1fb8495
Compare
TomasArrachea
force-pushed
the
tomasarrachea-migrate-to-package
branch
2 times, most recently
from
de1b3b3 to
e389b8d
Compare
TomasArrachea
force-pushed
the
tomasarrachea-migrate-to-package
branch
from
e389b8d to
5826321
Compare
TomasArrachea
changed the title
ExpirationTransactionScript in build-time
TomasArrachea
changed the title
ExpirationTransactionScript in build-timeExpirationTransactionScript to package
mmagician
reviewed
Jul 8, 2026
Collaborator
There was a problem hiding this comment.
I wonder if this belongs under asm/standards. We already have a notes sub-directory there which contain the known note scripts, and I think another sub-directory tx_scripts would mirror it well.
Or is there a reason why this needs to be its own package?
Collaborator
Author
There was a problem hiding this comment.
Agreed. In ccd8150 I changed it so the script is now a library procedure inside the standards package, marked with the @transaction_script annotation.
mmagician
approved these changes
Jul 9, 2026
mmagician
left a comment
mmagician
left a comment
Collaborator
There was a problem hiding this comment.
LGTM thanks! The structure looks much better imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2896.
Assembles the transaction expiration script into a Package on build-time instead of using the
CodeBuilder.TODO:
SendNotesTransactionScript. This requires changing the script to take advice inputs instead of handling them from strings. Will do it a separate PR.